Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ui-cargo tests in CI #5864

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix ui-cargo tests in CI #5864

merged 1 commit into from
Aug 3, 2020

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 3, 2020 •
edited
Loading

r? @ebroto

The ui-toml tests set the CARGO_MANIFEST_DIR var, but never reset it, so the ui-cargo tests used it also and then found a faulty clippy.toml file

changelog: none

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 3, 2020
@flip1995 flip1995 mentioned this pull request Aug 3, 2020
Merged
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2020

📌 Commit 0e44ed5 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Aug 3, 2020

⌛ Testing commit 0e44ed5 with merge bbbc973...

@bors
Copy link
Contributor

bors commented Aug 3, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing bbbc973 to master...

@bors bors merged commit bbbc973 into master Aug 3, 2020
@flip1995 flip1995 deleted the ci_debug branch August 3, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flip1995 @Manishearth @bors