Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 1.48 beta #6115

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Add changelog for 1.48 beta #6115

merged 2 commits into from
Oct 9, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented Oct 5, 2020

Rendered

I've not added the PRs fixing same_item_push because those were backported, namely:

The following PR was reverted, so I've ignored it too:

Also, I took the liberty of adding a "Thanks" section, naming all the contributors to this release. I think they deserve visibility in the changelog. Please tell me if we want to add this or maybe it's redundant given we link to the PRs?

changelog: none

r? @flip1995

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2020
@flip1995
Copy link
Member

flip1995 commented Oct 5, 2020

I think they deserve visibility in the changelog. Please tell me if we want to add this or maybe it's redundant given we link to the PRs?

I'm against that. I really do appreciate the work all of the volunteers are doing, don't get me wrong. But I don't think this benefits anyone.

Users of Clippy don't want/need to know who did the work, just that it works.
The contributors get nothing out of it (except their name GH tag in a document, but I don't see what this does for them).
And we maintainers benefit the least from this, since we can only forget someone who then complains.

Also Clippy contributions are already tracked at https://thanks.rust-lang.org. You can even change your GitHub tag there with your real name, which might be useful for your CV, if companies look at something like open source contributions. (I have it in my CV lol 😄).

@ebroto
Copy link
Member Author

ebroto commented Oct 5, 2020

Users of Clippy don't want/need to know who did the work, just that it works.
The contributors get nothing out of it (except their name GH tag in a document, but I don't see what this does for them).
And we maintainers benefit the least from this, since we can only forget someone who then complains.

Alright, those seem fair points. At that moment it seemed like a good way to give something back for all the work (some recognition), but I think you're right and the changelog is not the place to do that.

@flip1995
Copy link
Member

flip1995 commented Oct 9, 2020

@bors r+

Thanks! And this concludes the release process 🎉

@bors
Copy link
Contributor

bors commented Oct 9, 2020

📌 Commit 13781ae has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 9, 2020

⌛ Testing commit 13781ae with merge 6fb3b2c...

@bors
Copy link
Contributor

bors commented Oct 9, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 6fb3b2c to master...

@bors bors merged commit 6fb3b2c into rust-lang:master Oct 9, 2020
@ebroto ebroto deleted the changelog_1_48 branch October 9, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants