Sync from rust #6121
Closed
Sync from rust #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to forbidding foo.
…e-forbid-in-same-scope, r=petrochenkov Disallow overriding forbid in same scope Rebased #73379. Fixes #70819.
Fix LitKind's byte buffer to use refcounted slice While working on adding a new lint for clippy (see rust-lang#6044) for avoiding shared ownership of "mutable buffer" types (such as using `Rc<Vec<T>>` instead of `Rc<[T]>`), I noticed a type exported from rustc_ast and used by clippy gets caught by the lint. This PR fixes the exported type. This PR includes the actual change to clippy too, but I will open a PR directly against clippy for that part (although it will currently fail to build there).
|
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @flip1995 just in case you also have sync plans |
|
Actually, this seems fine @bors r+ |
|
📌 Commit 18db93d has been approved by |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Sync from rust Not much to say here, other than it includes an update for a breaking change from rustc_ast changelog: none
|
💔 Test failed - checks-action_test |
Merged
|
Thanks for syncing. Between the sync and the bors run was another breakage. I resynced and opened #6126. Help in the sync process is always welcome though! |
bors
added a commit
that referenced
this pull request
Oct 6, 2020
Rustup Supersedes #6121. There was another breakage. r? `@ghost` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to say here, other than it includes an update for a breaking change from rustc_ast
changelog: none