Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not run clippy for cargo clippy -- -W help #6125

Closed
wants to merge 1 commit into from

Conversation

bnjjj
Copy link

@bnjjj bnjjj commented Oct 6, 2020

close #6122
Allow cli to display available lints without running the clippy process.

Let me know if the wrapper_mode is still relevant at this location in the source code.

Thanks for your review :)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @phansch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2020
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj
Copy link
Author

bnjjj commented Oct 6, 2020

Btw would you mind if I add a --json flag to display a json of all available lints ? It would be more machine readable

@bors
Copy link
Contributor

bors commented Oct 6, 2020

☔ The latest upstream changes (presumably #6126) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@flip1995
Copy link
Member

flip1995 commented Oct 6, 2020

Thanks for your contribution! Sadly I have to close this, see #6122 (comment) for details. The situation here can still be improved and I would be happy if you could get back to this!

@flip1995 flip1995 closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo clippy -- -W help runs clippy
5 participants