Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the generated files by update-references.sh if they are empty #6158

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

giraffate
Copy link
Contributor

An empty file may be generated by update-references.sh and committed as is when creating a patch like #6101 (comment) and #6079 (review). So, I think it would be helpful to add documentation, and automatically remove the generated file if it's empty.

changelog: none

@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 11, 2020
@phansch
Copy link
Member

phansch commented Oct 12, 2020

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Oct 12, 2020

📌 Commit 377d1fa has been approved by phansch

@bors
Copy link
Contributor

bors commented Oct 12, 2020

⌛ Testing commit 377d1fa with merge 18ffea0...

@bors
Copy link
Contributor

bors commented Oct 12, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 18ffea0 to master...

@bors bors merged commit 18ffea0 into rust-lang:master Oct 12, 2020
@giraffate giraffate deleted the improve_updating_references branch October 12, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants