-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint for comparing to empty slices instead of using .is_empty() #6226
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your (almost perfect) first contribution and welcome to Clippy! <3
Co-authored-by: Philipp Krones <hello@philkrones.com>
Thanks, and thank you for the review |
@bors r+ Thanks! |
📌 Commit e3de544 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Hey first time making a clippy lint
I added the implementation of the lint the
len_zero
since it shared a lot of the code, I would otherwise have to rewrite. Just tell me if the lint should use it's own file insteadchangelog: Add lint for comparing to empty slices
Fixes #6217