-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map_clone with deref and clone #6269
Conversation
r? @ebroto (rust_highfive has picked a reviewer for you, use r? to override) |
be95f39
to
93e204a
Compare
Learning as I go... I'm changing my implementation to check for autoderef adjustments instead of checking for |
☔ The latest upstream changes (presumably #6301) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
|
93e204a
to
51d1cd5
Compare
Rebased to fix the merge conflict. |
Thanks for keeping this up to date. And thanks for all your recent contributions! Sadly currently almost all of our maintainers are busy with IRL stuff and only get to review a few times a week at best. |
No worries! |
51d1cd5
to
7690944
Compare
@bors r+ Thanks! (for this and for Polite 😄) |
📌 Commit 7690944 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: Fix map_clone false positive with deref coercion
Fixes #6239