Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in adding_lints.md #6276

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Fix typo in adding_lints.md #6276

merged 1 commit into from
Oct 31, 2020

Conversation

dp304
Copy link
Contributor

@dp304 dp304 commented Oct 31, 2020

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2020
@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2020

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2020

📌 Commit 22a958d has been approved by llogiq

@bors
Copy link
Contributor

bors commented Oct 31, 2020

⌛ Testing commit 22a958d with merge fbc1eeb...

bors added a commit that referenced this pull request Oct 31, 2020
Fix typo in adding_lints.md

changelog: none
@bors
Copy link
Contributor

bors commented Oct 31, 2020

💔 Test failed - checks-action_test

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2020

Error seems unrelated, we may need a rustup here.

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2020

Let's rebase when #6277 lands.

@dp304
Copy link
Contributor Author

dp304 commented Oct 31, 2020

Rebased.
I have a probably unrelated question: rustfmt is unavailable in the nightly builds since 2020-10-25, but that build is too old, and seems to conflict with new changes in clippy.
How can I set up the dev environment so that the most recent rustc-nightly is available as well as a recent enough rustfmt?

@llogiq
Copy link
Contributor

llogiq commented Oct 31, 2020

Type ./setup_environment.sh in your clippy project folder.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2020

📌 Commit edfa13d has been approved by llogiq

@bors
Copy link
Contributor

bors commented Oct 31, 2020

⌛ Testing commit edfa13d with merge e298c83...

@bors
Copy link
Contributor

bors commented Oct 31, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing e298c83 to master...

@bors bors merged commit e298c83 into rust-lang:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants