do not trigger MATCH_LIKE_MATCHES_MACRO lint with attrs

[alex-700]

fixed #6289
changelog: do not trigger MATCH_LIKE_MATCHES_MACRO lint for arms with attrs

[rust-highfive]

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

[matthiaskrgr]

Thanks!
@bors r=matthiaskrgr

[bors]

📌 Commit c6efae9 has been approved by matthiaskrgr

[bors]

⌛ Testing commit c6efae9 with merge b7715f2...

[bors]

💔 Test failed - checks-action_test

[matthiaskrgr]

You need to update the .fixed file as well https://github.com/rust-lang/rust-clippy/runs/1365306167#step:13:1203

[alex-700]

@matthiaskrgr it's not easy :) The current .fixed file is correct. CI failed because of the bug in my implementation. I didn't take into account that LateLintPass already dropped cfg attributes, if it resolved them into false (if I got it right). And ... I don't know how to fix this. Any ideas?

[flip1995]

I don't think we can fix this at all. cfg attributes are already resolved before the AST is even built, so clippy doesn't have access to them. What we can do is mention this in the lint documentation and set the applicability to MaybeIncorrect

[giraffate]

ping from triage @alex-700. Could you have any update on this?

[alex-700]

@giraffate thanks for ping!

I decided don't add this failed test with attributes, but anyway my changes in lint code do their best and don't lint if "see" some arms with attrs. For example it doesn't lint in the initial case mentioned by @matthiaskrgr (in the case when target_os is indeed linux). Also I add a note to known problems and change the applicability to MaybeIncorrect.

"tests failed" in clippy dogfood doesn't seem to be relevant to this PR.

[flip1995]

@bors r+

Thanks!

[bors]

📌 Commit 84cdb0a has been approved by flip1995

[bors]

⌛ Testing commit 84cdb0a with merge b627731...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b627731 to master...