Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc about map_clone #6340

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

giraffate
Copy link
Contributor

A follow up of #6239 (comment).

map_clone works with not only Iterator but Option although not written in doc. Also, an example in the doc shows a usage of dereferencing, but this isn't also written.

changelog: Improve doc about map_clone

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 17, 2020
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Nov 18, 2020

📌 Commit 0502ac2 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Nov 18, 2020

⌛ Testing commit 0502ac2 with merge 8c2e2fd...

@bors
Copy link
Contributor

bors commented Nov 18, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 8c2e2fd to master...

@bors bors merged commit 8c2e2fd into rust-lang:master Nov 18, 2020
@giraffate giraffate deleted the improve_doc_for_map_clone branch November 18, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants