Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix4894 Using Into and TryInto instead of From and TryFrom #6620

Closed
wants to merge 28 commits into from
Closed

Fix4894 Using Into and TryInto instead of From and TryFrom #6620

wants to merge 28 commits into from

Commits on Feb 24, 2021

  1. cargo dev new_lint.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    9a68b0c View commit details
    Browse the repository at this point in the history

  2. Add test.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ef88eac View commit details
    Browse the repository at this point in the history

  3. Lint declaration.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    2461b29 View commit details
    Browse the repository at this point in the history

  4. is_diagnostic_item doesn't trigger the lint.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    81bb1ec View commit details
    Browse the repository at this point in the history

  5. Rename lint into into_instead_of_from.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    5d1f388 View commit details
    Browse the repository at this point in the history

  6. Move if condiction from then block out.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    90b86b5 View commit details
    Browse the repository at this point in the history

  7. Fixed mistake made in rebase, test try_from_trait.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    5e5730b View commit details
    Browse the repository at this point in the history

  8. Remove extra is diagnositc item check.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    bc9481f View commit details
    Browse the repository at this point in the history

  9. Documentation.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d7c5152 View commit details
    Browse the repository at this point in the history

  10. Waiting to fill sugg.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d7822db View commit details
    Browse the repository at this point in the history

  11. Emit suggestion.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d0d3698 View commit details
    Browse the repository at this point in the history

  12. Rename lint.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e4013af View commit details
    Browse the repository at this point in the history

  13. Satisfy with test.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3d8a1ea View commit details
    Browse the repository at this point in the history

  14. Update lints.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    62ab8da View commit details
    Browse the repository at this point in the history

  15. cargo dev fmt.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    b04f8a1 View commit details
    Browse the repository at this point in the history

  16. Update test files after fmt.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    72e4786 View commit details
    Browse the repository at this point in the history

  17. Using From trait in this test is irrelevant.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    c4cae20 View commit details
    Browse the repository at this point in the history

  18. Suggestion may be incorrect. 

    Co-authored-by: Philipp Krones <hello@philkrones.com>
    @xiongmao86 @flip1995
    xiongmao86 and flip1995 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    236b82e View commit details
    Browse the repository at this point in the history

  19. Migrate to use find.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    95c1123 View commit details
    Browse the repository at this point in the history

  20. Work with multiply bounds now.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    867a07f View commit details
    Browse the repository at this point in the history

  21. Update due to review suggestion.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    cf542a2 View commit details
    Browse the repository at this point in the history

  22. Fix wrong filter closure.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    32d4643 View commit details
    Browse the repository at this point in the history

  23. Finish lint logic, add 1 more case for test.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    04b00ea View commit details
    Browse the repository at this point in the history

  24. Satisfy with test.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    655520f View commit details
    Browse the repository at this point in the history

  25. Refactor and update test.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    9eea1b6 View commit details
    Browse the repository at this point in the history

  26. Fix workspace warning.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ae2b38d View commit details
    Browse the repository at this point in the history

  27. Using span_lint_and_then method to lint.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    94232f3 View commit details
    Browse the repository at this point in the history

  28. Reference for pull request.

    @xiongmao86
    xiongmao86 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    785d607 View commit details
    Browse the repository at this point in the history