Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lint: bytes_nth #6695

Merged
merged 3 commits into from
Feb 10, 2021
Merged

New lint: bytes_nth #6695

merged 3 commits into from
Feb 10, 2021

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Feb 7, 2021

This pull request adds a new lint named bytes_nth.


closes: #6391

changelog: Added a new lint: bytes_nth

@rust-highfive
Copy link

r? @phansch

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 7, 2021
@TaKO8Ki TaKO8Ki changed the title Add a new lint bytes_nth New lint: bytes_nth Feb 7, 2021
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I just have some minor comments =)

clippy_lints/src/methods/bytes_nth.rs Outdated Show resolved Hide resolved
tests/ui/bytes_nth.rs Show resolved Hide resolved
TaKO8Ki and others added 2 commits February 10, 2021 15:49
@TaKO8Ki TaKO8Ki requested a review from phansch February 10, 2021 07:26
@phansch
Copy link
Member

phansch commented Feb 10, 2021

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Feb 10, 2021

📌 Commit 5996ae1 has been approved by phansch

@bors
Copy link
Contributor

bors commented Feb 10, 2021

⌛ Testing commit 5996ae1 with merge b5e4389...

@bors
Copy link
Contributor

bors commented Feb 10, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing b5e4389 to master...

@bors bors merged commit b5e4389 into rust-lang:master Feb 10, 2021
@TaKO8Ki TaKO8Ki deleted the add-bytes-nth branch February 10, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint to prevent people from indexing a string via iterator.nth(i)
4 participants