Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Lint: needless_for_each #6706

Merged
merged 14 commits into from
Mar 31, 2021
Merged

New Lint: needless_for_each #6706

merged 14 commits into from
Mar 31, 2021

Commits on Mar 31, 2021

  1. New Lint: excessive_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5029dc8 View commit details
    Browse the repository at this point in the history

  2. Fix codes that fails dogfood

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    3095253 View commit details
    Browse the repository at this point in the history

  3. Change a category of excessive_for_each: Style -> Restriction

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    54a0471 View commit details
    Browse the repository at this point in the history

  4. Trigger the lint iff exposure's body is ExprKind::Block.

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5bb0f16 View commit details
    Browse the repository at this point in the history

  5. Avoid to suggest using label

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    90cbbb2 View commit details
    Browse the repository at this point in the history

  6. Refactor: Remove duplicated codes from excessive_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ccd7a60 View commit details
    Browse the repository at this point in the history

  7. Add comments to clarify why RetCollector is needed

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    25d8b94 View commit details
    Browse the repository at this point in the history

  8. Improve the document of excessive_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    3843171 View commit details
    Browse the repository at this point in the history

  9. Use ".." as default value of snippet in excessive_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    5543c34 View commit details
    Browse the repository at this point in the history

  10. Refactor excessive_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    527fbbe View commit details
    Browse the repository at this point in the history

  11. Remove method_calls

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f2cc995 View commit details
    Browse the repository at this point in the history

  12. Fix codes that make dogfood fail

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    1109dc8 View commit details
    Browse the repository at this point in the history

  13. Skip needless_for_each if an input stmt is local

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    bf1e3f7 View commit details
    Browse the repository at this point in the history

  14. Tweak a suggestion message of needless_for_each

    @Y-Nak
    Y-Nak committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    e61f978 View commit details
    Browse the repository at this point in the history