Teach SpanlessEq binding IDs #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
reviewed
Feb 18, 2021
|
@bors r+ Thanks! |
|
📌 Commit 9ad6e26 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix collapsible_match false positive
Fixes #6740
This PR changes the way
SpanlessEqdetermines whether two local variables are the same. Instead of checking that the names match, it checks that theHirIds match. If local bindings are declared within the expressions that are being compared,SpanlessEqwill remember bindings that correspond to each other in aFxHashMap<HirId, HirId>. This makesSpanlessEqmore flexible while also fixing false positives.Example:
{ let x = 1; x + 2 }is equal to{ let y = 1; y + 2 }.CC @xFrednet I think this will resolve some concerns in #6463