Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unnecessary_wraps to pedantic #6765

Merged
merged 2 commits into from
Feb 21, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: Change unnecessary_wraps to pedantic

There seems to be enough evidence that this lint is not wanted as warn-by-default. Attempted before at #6380. False positives at #6721 and #6427. Actually requested to change the category at #6726.

Closes #6726

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 19, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Feb 21, 2021

📌 Commit 46c91db has been approved by flip1995

@bors
Copy link
Contributor

bors commented Feb 21, 2021

⌛ Testing commit 46c91db with merge 8a47901...

@bors
Copy link
Contributor

bors commented Feb 21, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8a47901 to master...

@bors bors merged commit 8a47901 into rust-lang:master Feb 21, 2021
@camsteffen camsteffen deleted the unnecessary-wraps-pedantic branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unnecessary_wraps is a bad default lint
4 participants