Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write literal suggestion #6821

Merged
merged 4 commits into from
Mar 17, 2021
Merged

Write literal suggestion #6821

merged 4 commits into from
Mar 17, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Mar 1, 2021 •
edited
Loading

fixes: #6768

changelog: Add suggestion to write_literal and print_literal lints
changelog: Change use_debug to point only at the format string

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 1, 2021
@Jarcho Jarcho force-pushed the write_literal_suggestion branch from 7537128 to a15f9ee Compare March 1, 2021 23:11
flip1995
flip1995 reviewed Mar 15, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long! This looks overall really good! I just have two NITs.

clippy_lints/src/write.rs Outdated Show resolved Hide resolved
clippy_lints/src/write.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 15, 2021
@bors
Copy link
Contributor

bors commented Mar 16, 2021

☔ The latest upstream changes (presumably #6914) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995
flip1995 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, otherwise LGTM.

@Jarcho
Add suggestion to write_literal and print_literal
a7fa2a6 
Don't lint on a mixture of raw and regular strings
Fix spans in format strings
@Jarcho Jarcho force-pushed the write_literal_suggestion branch from b130ce0 to 6946cc1 Compare March 16, 2021 16:14
@Jarcho Jarcho force-pushed the write_literal_suggestion branch from 6946cc1 to d45873b Compare March 16, 2021 16:27
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Mar 17, 2021

📌 Commit d45873b has been approved by flip1995

@bors
Copy link
Contributor

bors commented Mar 17, 2021

⌛ Testing commit d45873b with merge d695bfc...

@bors
Copy link
Contributor

bors commented Mar 17, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d695bfc to master...

@bors bors merged commit d695bfc into rust-lang:master Mar 17, 2021
@Jarcho Jarcho deleted the write_literal_suggestion branch April 6, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

questionable write_literal warning: write!(f, "{}", "{integer}")
4 participants
@Jarcho @rust-highfive @bors @flip1995