len_without_is_empty will now consider multiple impl blocks
#6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Manishearth
requested changes
Mar 5, 2021
Jarcho
force-pushed
the
len_without_is_empty_fp
branch
4 times, most recently
from
a585672
to
614637f
Compare
|
☔ The latest upstream changes (presumably #6823) made this pull request unmergeable. Please resolve the merge conflicts. |
`len_without_is_empty` will now consider `#[allow]` on both the `len` method, and the type definition
Jarcho
force-pushed
the
len_without_is_empty_fp
branch
from
614637f
to
47145de
Compare
|
@bors r+ thanks! |
|
📌 Commit 47145de has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1562
This also reverts #1559 as the
#[allow]now works on thelenmethod. A note has also been added to point out where theemptymethod is, if it exists.changelog:
len_without_is_emptywill now consider multiple impl blockschangelog:
len_without_is_emptywill now consider#[allow]on both thelenmethod, and the type definition