Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSRV options to unnested_or_patterns #6977

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Add MSRV options to unnested_or_patterns #6977

merged 3 commits into from
Mar 26, 2021

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Mar 26, 2021 •
edited
Loading

changelog: [unnested_or_patterns] can now be configured with the msrv config/attribute.

Fixes #6953

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 26, 2021
xFrednet
xFrednet approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation updates LGTM. The code as well, especially with the docs, but it might be good if someone who has worked with msrv double-checks the changes 🙃

@flip1995 flip1995 mentioned this pull request Mar 26, 2021
Merged
@flip1995
Copy link
Member Author

The only one assigned to PRs that really dealt with the MSRV feature was me 😄

llogiq
llogiq reviewed Mar 26, 2021
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, otherwise LGTM.

clippy_lints/src/unnested_or_patterns.rs Outdated Show resolved Hide resolved
clippy_lints/src/unnested_or_patterns.rs Outdated Show resolved Hide resolved
@flip1995
Copy link
Member Author

I just moved everything in the if block for consistency 👍

@llogiq
Copy link
Contributor

llogiq commented Mar 26, 2021

👍 @bors r+

@bors
Copy link
Contributor

bors commented Mar 26, 2021

📌 Commit 5279b59 has been approved by llogiq

@bors
Copy link
Contributor

bors commented Mar 26, 2021

⌛ Testing commit 5279b59 with merge 6f2a6fe...

@bors
Copy link
Contributor

bors commented Mar 26, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 6f2a6fe to master...

@bors bors merged commit 6f2a6fe into rust-lang:master Mar 26, 2021
@flip1995 flip1995 deleted the or_patterns_msrv branch March 26, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq left review comments

@xFrednet xFrednet xFrednet approved these changes

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnested_or_patterns does not respect clippy.toml msrv
5 participants
@flip1995 @rust-highfive @llogiq @bors @xFrednet