Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid null usage v2 #7023

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Invalid null usage v2 #7023

merged 1 commit into from
Apr 8, 2021

Conversation

boxdot
Copy link
Contributor

@boxdot boxdot commented Apr 3, 2021 •
edited
Loading

This is continuation of #6192 after inactivity.

I plan to move paths into the compiler as diagnostic items after this is merged.

fixes #1703
changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 3, 2021
@boxdot boxdot mentioned this pull request Apr 3, 2021
Closed
@camsteffen
Copy link
Contributor

Thanks for picking this back up. Would you mind squashing your changes into fewer commits? I will try to be mindful of history from the previous PR.

@boxdot boxdot force-pushed the invalid-null-usage-v2 branch from 2ff8e6d to 96519fa Compare April 3, 2021 19:59
@boxdot
Copy link
Contributor Author

boxdot commented Apr 6, 2021

Thanks for picking this back up. Would you mind squashing your changes into fewer commits? I will try to be mindful of history from the previous PR.

Thank you for reviewing it again. In case there was no notification about the squash, just wanted to tell that the commits are squashed now.

camsteffen
camsteffen suggested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. I have a few comments.

clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Apr 6, 2021

☔ The latest upstream changes (presumably #6931) made this pull request unmergeable. Please resolve the merge conflicts.

@boxdot boxdot force-pushed the invalid-null-usage-v2 branch from 96519fa to 39ae3c2 Compare April 7, 2021 19:21
boxdot
boxdot commented Apr 7, 2021
View reviewed changes
Copy link
Contributor Author

@boxdot boxdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I addressed you comments. Please tell me if commits should be squashed.

clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
@boxdot boxdot requested a review from camsteffen April 7, 2021 19:30
camsteffen
camsteffen suggested changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! I have a couple more comments. Let's wait to squash til the end.

clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_utils/src/paths.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
@boxdot boxdot requested a review from camsteffen April 8, 2021 19:31
camsteffen
camsteffen suggested changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more nits.

clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
clippy_lints/src/ptr.rs Outdated Show resolved Hide resolved
@boxdot boxdot requested a review from camsteffen April 8, 2021 20:37
camsteffen
camsteffen approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@camsteffen camsteffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@boxdot boxdot force-pushed the invalid-null-usage-v2 branch from de7d0ea to 4f7fc11 Compare April 8, 2021 20:49
@boxdot
Copy link
Contributor Author

boxdot commented Apr 8, 2021

Looks good!

Thank you. Squashed.

@camsteffen
Copy link
Contributor

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2021

📌 Commit 4f7fc11 has been approved by camsteffen

@bors
Copy link
Contributor

bors commented Apr 8, 2021

⌛ Testing commit 4f7fc11 with merge 75efc14...

@bors
Copy link
Contributor

bors commented Apr 8, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing 75efc14 to master...

@bors bors merged commit 75efc14 into rust-lang:master Apr 8, 2021
@bors bors mentioned this pull request Apr 8, 2021
Merged
@boxdot boxdot deleted the invalid-null-usage-v2 branch April 9, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsteffen camsteffen camsteffen approved these changes

Assignees

@camsteffen camsteffen

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lint the use of from_raw_parts with a constant null pointer
4 participants
@boxdot @rust-highfive @camsteffen @bors