Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider mutability on useless_vec suggestions #7036

Merged
merged 1 commit into from
Apr 6, 2021
Merged

consider mutability on useless_vec suggestions #7036

merged 1 commit into from
Apr 6, 2021

Conversation

horacimacias
Copy link

@horacimacias horacimacias commented Apr 5, 2021 •
edited by giraffate
Loading

fixes #7035

changelog: Now the suggested by useless_vec considers mutability to suggest either &[], as before, or &mut [] if the used reference is mutable.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 5, 2021
@giraffate
Copy link
Contributor

Thanks for your work, and welcome to Clippy!

Overall looks good.
The test looks to fail because of formatting, so can you update on this? This document is helpful: https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#running-rustfmt.
Also, can you squash commits?

@horacimacias
Copy link
Author

thanks!
I've formatted and squashed.
I think it should be good now.

giraffate
giraffate approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@giraffate giraffate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

tests/ui/vec.rs Outdated Show resolved Hide resolved
@giraffate
Copy link
Contributor

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 6, 2021

📌 Commit 8a50923 has been approved by giraffate

@bors
Copy link
Contributor

bors commented Apr 6, 2021

⌛ Testing commit 8a50923 with merge c18bcff...

bors added a commit that referenced this pull request Apr 6, 2021
@bors
Auto merge of #7036 - horacimacias:master, r=giraffate
c18bcff 
consider mutability on useless_vec suggestions

fixes #7035

changelog:
Now the suggested text considers mutability to suggest either `&[]`, as before, or `&mut []` if the used reference is mutable.
@bors
Copy link
Contributor

bors commented Apr 6, 2021

💔 Test failed - checks-action_test

@giraffate
Copy link
Contributor

@bors retry

@bors
Copy link
Contributor

bors commented Apr 6, 2021

⌛ Testing commit 8a50923 with merge d2ba777...

@bors
Copy link
Contributor

bors commented Apr 6, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing d2ba777 to master...

@bors bors merged commit d2ba777 into rust-lang:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giraffate giraffate giraffate approved these changes

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useless_vec does not consider mutability
5 participants
@horacimacias @rust-highfive @giraffate @bors @hmacias-avaya