Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog check output #7070

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Fix changelog check output #7070

merged 1 commit into from
Apr 14, 2021

Conversation

camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Apr 12, 2021 •
edited
Loading

Error messages are more helpful if you can see them.

changelog: none

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 12, 2021
@camsteffen

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Apr 12, 2021
@bors
Auto merge of #7070 - camsteffen:changelog-stderr, r=camsteffen
9716126 
Output changelog error to stderr

Error messages are more helpful if you can see them.
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@camsteffen

This comment has been minimized.

Sign in to view
@flip1995

This comment has been minimized.

Sign in to view
@camsteffen

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Apr 12, 2021
@bors
Auto merge of #7070 - camsteffen:changelog-stderr, r=camsteffen
21d3a68 
Output changelog error to stderr

Error messages are more helpful if you can see them.
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@camsteffen
Copy link
Contributor Author

Got it. It was silently failing at grep because pipefail is enabled. Will add a changelog so this can be reviewed/merged.

@camsteffen camsteffen changed the title Output changelog error to stderr Fix changelog check output Apr 12, 2021
@camsteffen

This comment has been minimized.

Sign in to view
flip1995
flip1995 reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use bors try for PRs like this, to avoid accidentally merging stuff. It does the same as r+, but will never merge.

.github/workflows/clippy_bors.yml Outdated Show resolved Hide resolved
@camsteffen

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Apr 13, 2021
@bors
Auto merge of #7070 - camsteffen:changelog-stderr, r=<try>
e9bd75a 
Fix changelog check output

Error messages are more helpful if you can see them.

changelog:
@bors

This comment has been minimized.

Sign in to view
@camsteffen

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Apr 13, 2021
@bors
Auto merge of #7070 - camsteffen:changelog-stderr, r=<try>
9ab8b54 
Fix changelog check output

Error messages are more helpful if you can see them.

changelog:
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@camsteffen

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
bors added a commit that referenced this pull request Apr 13, 2021
@bors
Auto merge of #7070 - camsteffen:changelog-stderr, r=<try>
4460d55 
Fix changelog check output

Error messages are more helpful if you can see them.

changelog:  this is a test
@camsteffen camsteffen requested a review from flip1995 April 13, 2021 19:56
@bors
Copy link
Contributor

bors commented Apr 13, 2021

☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Build commit: 4460d55 (4460d55778293d56df50f4914a30f5048746c348)

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 14, 2021

📌 Commit 0d14429 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Apr 14, 2021

⌛ Testing commit 0d14429 with merge b1c675f...

@bors
Copy link
Contributor

bors commented Apr 14, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing b1c675f to master...

@bors bors merged commit b1c675f into rust-lang:master Apr 14, 2021
@camsteffen camsteffen deleted the changelog-stderr branch July 8, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 Awaiting requested review from flip1995

Assignees

@giraffate giraffate

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camsteffen @rust-highfive @bors @flip1995 @giraffate