Fixing FPs for the branches_sharing_code lint
#7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
camsteffen
reviewed
Apr 13, 2021
flip1995
reviewed
Apr 14, 2021
xFrednet
force-pushed
the
7054-fp-branches-sharing-code
branch
from
b0e9bff to
ecf13a5
Compare
xFrednet
force-pushed
the
7054-fp-branches-sharing-code
branch
from
ecf13a5 to
0b4af72
Compare
flip1995
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
LGTM. If @camsteffen doesn't have any objections, this is ready to merge 👍
|
@bors r=camsteffen,flip1995 |
|
📌 Commit 0b4af72 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7053
Fixes #7054
And an additional CSS adjustment to support dark mode for every inline code. It currently only works in paragraphs, which was an oversight on my part 😅. Current Example
This also includes ~50 lines of doc comments and is therefor not as big as the changes would indicate. 🐧
changelog: none
All of these bugs were introduced in this dev version and are therefor not worth a change log entry.
r? @phansch
cc: @camsteffen since you have a pretty good overview of the
SpanlessEqimplementation 🙃