Don't lint multiple_inherent_impl with generic arguments
#7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @camsteffen (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
multiple_impls_generic
branch
from
84f8cac to
23ddf7a
Compare
|
I don't think we should totally skip types with generic arguments. Instead we should detect if two impls have the exact same generic arguments. Since this is a restriction lint, some false positives are okay and even preferable to false negatives IMO. |
|
I'll keep this open while i look into it. |
Jarcho
force-pushed
the
multiple_impls_generic
branch
2 times, most recently
from
637cabb to
d962f37
Compare
|
That should do it. I'm not sure if that's the right way to add a dependency on |
Jarcho
force-pushed
the
multiple_impls_generic
branch
from
d962f37 to
0bb198c
Compare
camsteffen
reviewed
Apr 29, 2021
camsteffen
reviewed
Apr 29, 2021
camsteffen
reviewed
Apr 29, 2021
flip1995
reviewed
Apr 30, 2021
camsteffen
added
S-waiting-on-author
Jarcho
force-pushed
the
multiple_impls_generic
branch
2 times, most recently
from
d6841da to
d693380
Compare
camsteffen
suggested changes
May 10, 2021
Jarcho
force-pushed
the
multiple_impls_generic
branch
2 times, most recently
from
57d488a to
bd230fa
Compare
|
Please squash commits and r=me |
|
@bors delegate+ |
|
✌️ @Jarcho can now approve this pull request |
Treat different generic arguments as different types. Allow the lint to be ignored on the type definition, or any impl blocks.
Jarcho
force-pushed
the
multiple_impls_generic
branch
from
bd230fa to
760f703
Compare
|
@bors r+ |
|
📌 Commit 760f703 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5772
changelog: Treat different generic arguments as different types in
multiple_inherent_impl