Fix ICE checking for feature gated const fn #7128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
giraffate
reviewed
Apr 26, 2021
| // `rustc_mir::const_eval::is_const_fn` should return false for unstably const functions. | ||
| unreachable!(); | ||
| // Unstable const fn with the feature enabled. | ||
| msrv.is_none() |
There was a problem hiding this comment.
Why does the return value change here depending on whether MSRV is set?
There was a problem hiding this comment.
There's no stable rust version where the function is const as there's no stability attribute. If the MSRV is set, then the function is clearly not const. If it's not set, then the question becomes is the function const now, which is true.
|
@bors r+ Thanks! I also want to get this into the out of cycle sync: rust-lang/rust#84610 |
|
📌 Commit db7ad64 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7126
changelog: Fix ICE in
missing_const_for_fnwhen using a feature-gatedconst fn