-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conf
macro improvements part 2
#7154
Conversation
One documentation update missing: https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#adding-configuration-to-a-lint |
@bors r+ Thanks! |
📌 Commit ffb0951 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Lol, this backwards broke the beta deploy: 7c7683c Remind me in 6 weeks, that this will also break the stable 1.53 release deploy 😄 (Not your fault of course) |
What happened? |
The deploy workflow checks out the scripts from the current master branch, so we don't deploy an old state of the website for beta and releases. Otherwise it would use the deploy and website generation scripts that were in the repo at the point of the release (6/12 weeks ago). Especially when I first implemented the deploy workflow this lead to many failures of beta/stable deployment. Maybe we could use the python scripts in |
changelog: none
Follow-up to #7150
I made the default value required again for
define_Conf!
so that it can be parsed by the magic Python. I guess it's just as well for readability.r? @flip1995