needless_collect enhancements
#7188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `len` might produce different results than `count` - they don't have `contain` but `contains_key` method
Those two types are supported already when used indirectly. This commit adds support for direct usage as well.
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
reviewed
May 13, 2021
+ small code refactor - using early returns.
|
Your changes look good to me. You can resolve my comments 🙃 |
|
📌 Commit b249290 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7164
changelog:
needless_collect: ForBTreeMapandHashMaplint onlyis_empty, aslenmight produce different results than iter'scountchangelog:
needless_collect: LintLinkedListandBinaryHeapin direct usage case as well