-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move semicolon_if_nothing_returned
to pedantic
#7268
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ |
📌 Commit 1ac7e19 has been approved by |
Move `semicolon_if_nothing_returned` to `pedantic` This moves the `semicolon_if_nothing_returned` lint to `pedantic` category. I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR changelog: Move [`semicolon_if_nothing_returned`] lint into `pedantic` category.
💔 Test failed - checks-action_test |
Ah, we need to fix this lint for most of clippy (which runs under pedantic). I'm also okay |
@rustbot modify labels to +S-waiting-on-author -S-waiting-on-review |
I think this should all be good now. @rustbot label +S-waiting-on-review -S-waiting-on-author |
@bors r+ |
📌 Commit 0c017ea has been approved by |
Move `semicolon_if_nothing_returned` to `pedantic` This moves the `semicolon_if_nothing_returned` lint to `pedantic` category. I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR changelog: Move [`semicolon_if_nothing_returned`] lint into `pedantic` category.
💔 Test failed - checks-action_dev_test |
... And I forgot to format. @bors try |
@mbartlett21: 🔑 Insufficient privileges: not in try users |
@bors retry |
@bors r=Manishearth |
📌 Commit bcebea6 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This moves the
semicolon_if_nothing_returned
lint topedantic
category.I had done #7148, but on the master branch, and Github doesn't seem to let me change that, so here's another PR
changelog: Move [
semicolon_if_nothing_returned
] lint intopedantic
category.