Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bool_assert_comparaison] improve suggestion #7612

Closed
wants to merge 8 commits into from
Closed

[bool_assert_comparaison] improve suggestion #7612

wants to merge 8 commits into from

Commits on Oct 22, 2021

  1. improve suggestion for bool_assert_comparaison

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    90117a0 View commit details
    Browse the repository at this point in the history

  2. add extraction of fmt parameter

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    e696ba2 View commit details
    Browse the repository at this point in the history

  3. extract the formaing string and the values

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    3d17ede View commit details
    Browse the repository at this point in the history

  4. change to a structure for parsing assert macro

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    b079660 View commit details
    Browse the repository at this point in the history

  5. remove the format_string_expr from the FormatArgsExpn

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    5f5ea41 View commit details
    Browse the repository at this point in the history

  6. change based on review and debug_assert

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    256e6c5 View commit details
    Browse the repository at this point in the history

  7. add assert to the parsing

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    073dd99 View commit details
    Browse the repository at this point in the history

  8. reomove unecessary import

    @ABouttefeux
    ABouttefeux committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    103ac52 View commit details
    Browse the repository at this point in the history