Readme: note that config changes don't apply to already compiled code #8175
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
This is documenting what was (re-)discovered as part of #8145. |
|
Thank you! @bors r+ squash |
|
📌 Commit 67f73a3 has been approved by |
Readme: note that config changes don't apply to already compiled code *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: added a note to the Readme that config changes don't apply to already compiled code
|
💥 Test timed out |
|
It appears that the test runners have some intermittent problems. I'll ask infra. |
|
@bors retry |
Readme: note that config changes don't apply to already compiled code *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: added a note to the Readme that config changes don't apply to already compiled code
|
💔 Test failed - checks-action_remark_test |
|
The remark step itself was successful. It seems something's wrong with github's test infra. |
|
@bors retry |
Readme: note that config changes don't apply to already compiled code *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: added a note to the Readme that config changes don't apply to already compiled code
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
It seems that bors hasn't successfully pushed to master despite the tests being OK. @bors retry |
Readme: note that config changes don't apply to already compiled code *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: added a note to the Readme that config changes don't apply to already compiled code
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Ok, this seems to be a github UI problem where the PR is not marked as merge despite being the commit being merged to master (I just pulled and checked). |
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: added a note to the Readme that config changes don't apply to already compiled code