-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more fixes for transmute_undefined_repr
#8440
Conversation
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
Can we include the nurseryification and a comment linking to a followup about properly investigating this lint here? |
Is there a particular reason to not merge this separately from that considering there's already a pr for it? |
@bors r+ nah it's fine |
📌 Commit 1777841 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
☔ The latest upstream changes (presumably #8381) made this pull request unmergeable. Please resolve the merge conflicts. |
…a type containing a pointer
…and a type containing a fat pointer
1777841
to
d28d19d
Compare
@bors r+ |
📌 Commit d28d19d has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: Fix transmuting a struct containing a pointer into a pointer in
transmute_undefined_repr
changelog: Allow various forms of type erasure in
transmute_undefined_repr