Added copy lint name button to lint list

[Mastermindaxe]

Fixes #7959

changelog: Added 'copy lint name' button to lint list

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @camsteffen (or someone else) soon.

Please see the contribution instructions for more information.

[Mastermindaxe]

I added a tooltip for the button and an alert for when you've clicked it

[xFrednet]

I wanted this for quite some time now ❤️. I find the alert a bit distracting, but we should give some kind of visual feedback. Maybe an icon change like rustdoc has for items would be better.

->

rustdoc uses .svg images for that, we could also consider doing that if icons don't look so good. I think the current clipboard emoji is a little to small 🤔

---

Edit: Also, I think we should discuss if the name should be prefixed with clippy:: or not. For discussions, I usually just write the lint name without the prefix, but I expect this feature to be used by people on the fly to enable/disable a lint. Then it makes more sense to add the clippy:: prefix to use the lint directly in lint attributes 🤔

[camsteffen]

I agree we should avoid alert and there should be something that visually indicates "click here to copy to clipboard".

I also think it would be good to prefix clippy::, even if it's just for the clipboard and not actually on the page.

[Mastermindaxe]

Sounds like a plan. I'm gonna try to get these changes in over the next few days

@camsteffen What exactly do you mean by prefixing? Just putting clippy:: in front of the lint name in the clipboard? Wouldn't that defeat the purpose?
EDIT: Just saw the edited message by @xFrednet. Interesting point 🤔 Not sure how to solve this or decide on one way or the other

[xFrednet]

Thank you! To solve this, you can just add the prefix in line 504 like this (Or any other variation of JS string formatting.):

- navigator.clipboard.writeText(lint.id);
+ navigator.clipboard.writeText("clippy::" + lint.id);

I believe that most people would expect the prefix to be there. In discussions in this repo we often leave it out as the domain is clear, but having it wouldn't hurt. So, with some consideration, I would suggest prefixing it every time. 🙃

A second option would be to have a setting or key combination to control the prefix, but I believe that that is more confusing than helpful for 99% of the users.

If there are complaints / suggestions to remove the prefix it's an easy change :)

[xFrednet]

Hey @Mastermindaxe, are you still working on this? If you need any support, we're happy to help. 🙃

[Mastermindaxe]

Sorry for being inactive so long. Have been swamped with work and private stuff. I'm hoping that I can squeeze it in some time in the next two weeks. No promises but I'm trying!

[xFrednet]

No problem @Mastermindaxe and thank you for the response, if you're busy, you can also reach out. I'd be happy to add the finishing touches and ask another team member to review the final work 🙃

[xFrednet]

I'm closing this due to the long inactivity. If you have the time, feel free to reopen it 🙃.

Thank you very much for starting this implementation. I want to suggest this issue to another contributor and will reference this PR along with your work.