Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some #[clippy::version]s #8979

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

Alexendoo
Copy link
Member

Some were a bit off

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 9, 2022
@flip1995
Copy link
Member

flip1995 commented Jun 9, 2022

How did you find those incorrect versions? Do you think that there could be a way to automatically check those?

I trust you on the new version numbers 👍

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2022

📌 Commit 2b655d4 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jun 9, 2022

⌛ Testing commit 2b655d4 with merge 65f518e...

@xFrednet
Copy link
Member

xFrednet commented Jun 9, 2022

I think this issue would be solved by having nightly lint's and then set the version on a sync, when we enable/release new lints.

I still have the nightly lint Implementation in my backlog, but I'm held up on some implementation details. Until then it would be cool, to detect this somehow 👍

@Alexendoo
Copy link
Member Author

I did it using a rather hacky script that installed a bunch of stable toolchains and checked for the lint names in the output of clippy-driver -W help

Detecting it automatically would be nice, maybe metadata collector could parse the changelog New Lints sections in the meanwhile

@bors
Copy link
Collaborator

bors commented Jun 9, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 65f518e to master...

@bors bors merged commit 65f518e into rust-lang:master Jun 9, 2022
@flip1995
Copy link
Member

flip1995 commented Jun 9, 2022

The way I would go about it is checking out the gh-pages branch and write a script tracking when a new lint impl was added and comparing it with the version in the documentation.

But yeah, once we have nightly lints, and a stabilization procedure for those in place, automating it will be way easier.

@Alexendoo Alexendoo deleted the version-numbers branch June 9, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants