Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[never_loop]: Fix FP with let..else statements. #9496

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[never_loop]: Fix FP with let..else statements. #9496

merged 1 commit into from
Sep 23, 2022

Conversation

yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Sep 19, 2022

Fixes #9356

This has been bugging me for a while, so I thought I'd take a stab at it! I'm completely uncertain about the quality of my code, but I think it's an alright start, so opening this PR to get some feedback from more experienced clippy people :)

changelog: [never_loop]: Fix FP with let..else statements

@rust-highfive
Copy link

r? @Jarcho

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 19, 2022
@Jarcho
Copy link
Contributor

Jarcho commented Sep 23, 2022

Looks good. Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Sep 23, 2022

📌 Commit d63aece has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 23, 2022

⌛ Testing commit d63aece with merge ff65eec...

@bors
Copy link
Contributor

bors commented Sep 23, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing ff65eec to master...

@bors bors merged commit ff65eec into rust-lang:master Sep 23, 2022
@yotamofek yotamofek deleted the never_loop_let_else branch September 24, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

never_loop misses continue stmt inside let..else terminator
4 participants