new implicit_saturating_add lint
#9549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r?@llogiq |
roynrishingha
changed the title
manual_saturating_add lintimplicit_saturating_add lint
llogiq
reviewed
Oct 1, 2022
tests/ui/manual_saturating_add.rs
Outdated
| if u8::MAX > a { | ||
| b += 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd like to see tests against additional.statements in either then or else branch (noting that this led to false positives in the implicit-saturating-sub lint).
|
I think you'll need to rebase on current master before CI will run. |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9393
If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.
.stderrfile)cargo testpasses locallycargo dev update_lintscargo dev fmtchangelog: add [
manual_saturating_add] lint