allow new lines and comments in lambda parameters #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonwilliams can we get some of these syntax fixes merged, the current default is far from what it will be after all these merge |
|
@dten I think Jason is on vacation for the next week, so it'll probably be delayed for a little while. |
|
Doh I missed that |
|
Yes when I’m back I will try to merge some more of these, @dten are you able to join the official Rust discord? https://discord.gg/JTcKGAy Ping me once you’re in there. |
|
@dten conflict here |
|
that was the world's most mundane conflict 🎉 |
|
@dten sorry, but as i was merging in the other PRs i caused another conflict :/ |
|
what i didn't get was that it wasn't really a conflict, i added something to the bottom of a file, so did someone else (we both added tests) i've no idea why it would complain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #284 6 and 7