Allow specifying the wanted compression formats at runtime #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--compression-formatsoption to thegenerate,combineandtarballsubcommands, allowing to choose one or more output formats to generate. If the flag is not present the default set of formats is generated (gzandxz):The
combinesubcommand is also tweaked to allow combining tarballs compressed using any of the supported formats, instead of only allowing gzip-compressed tarballs.All of this will allow rustc's CI to choose which formats to generate, and it will allow to easily add new formats in the future.
This PR can be reviewed commit-by-commit.
r? @alexcrichton