Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Blocking waiting for file lock ..." cargo messages are not ignored #499

Open
dimonomid opened this issue May 17, 2023 · 0 comments · May be fixed by #500
Open

"Blocking waiting for file lock ..." cargo messages are not ignored #499

dimonomid opened this issue May 17, 2023 · 0 comments · May be fixed by #500

Comments

@dimonomid
Copy link

rust.vim version: master (889b9a7515db477f4cb6808bef1769e53493c578)

Steps to reproduce:

Trigger :make from Vim while some other build of the same project is in progress. It happens all the time if one uses rust-analyzer, saves a Rust source file and quickly triggers make, like :w | :make which I do often: once the file is saved, rust-analyzer performs the build automatically, and by the time Vim tries to build it as well, it has to wait for the other build to finish, and cargo prints lines like Blocking waiting for file lock on package cache.

Expected vs. actual behavior:

Expected those lines to be ignored by Vim, and not included in quickfix, however they are included in quickfix, and even if the build succeeded, the quickfix is non-empty, making it look like there are issues:

||     Blocking waiting for file lock on package cache
||     Blocking waiting for file lock on package cache
||     Blocking waiting for file lock on build directory
dimonomid added a commit to dimonomid/fork-of-rust.vim that referenced this issue May 17, 2023
Whenever Cargo tries to build a project while there is another build in
progress, Cargo will wait for the other build to finish, and print
messages like this:

```
Blocking waiting for file lock on package cache
Blocking waiting for file lock on package cache
Blocking waiting for file lock on build directory
```

Those messages were not ignored, and were therefore included in the
quickfix, making it look like there were some issues even if the build
succeeded.

This commit configures `&errorformat` to ignore those messages and avoid
including them in the quickfix.

Closes rust-lang#499 .
@dimonomid dimonomid linked a pull request May 17, 2023 that will close this issue
Notgnoshi pushed a commit to Notgnoshi/rust.vim that referenced this issue Dec 27, 2023
Whenever Cargo tries to build a project while there is another build in
progress, Cargo will wait for the other build to finish, and print
messages like this:

```
Blocking waiting for file lock on package cache
Blocking waiting for file lock on package cache
Blocking waiting for file lock on build directory
```

Those messages were not ignored, and were therefore included in the
quickfix, making it look like there were some issues even if the build
succeeded.

This commit configures `&errorformat` to ignore those messages and avoid
including them in the quickfix.

Closes rust-lang#499 .
Notgnoshi pushed a commit to Notgnoshi/rust.vim that referenced this issue Feb 16, 2024
Whenever Cargo tries to build a project while there is another build in
progress, Cargo will wait for the other build to finish, and print
messages like this:

```
Blocking waiting for file lock on package cache
Blocking waiting for file lock on package cache
Blocking waiting for file lock on build directory
```

Those messages were not ignored, and were therefore included in the
quickfix, making it look like there were some issues even if the build
succeeded.

This commit configures `&errorformat` to ignore those messages and avoid
including them in the quickfix.

Closes rust-lang#499 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant