Skip to content

Commit

Permalink
Rollup merge of #127451 - GuillaumeGomez:improve-output-type-permutat…
Browse files Browse the repository at this point in the history
…ions, r=kobzol

Improve `run-make/output-type-permutations` code and improve `filename_not_in_denylist` API

r? ``@Kobzol``
  • Loading branch information
jieyouxu authored Jul 8, 2024
2 parents ffb9336 + 39bb14e commit 0332834
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 2 additions & 1 deletion src/tools/run-make-support/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ pub fn not_contains<P: AsRef<Path>>(path: P, expected: &str) -> bool {
}

/// Returns true if the filename at `path` is not in `expected`.
pub fn filename_not_in_denylist<P: AsRef<Path>>(path: P, expected: &[String]) -> bool {
pub fn filename_not_in_denylist<P: AsRef<Path>, V: AsRef<[String]>>(path: P, expected: V) -> bool {
let expected = expected.as_ref();
path.as_ref()
.file_name()
.is_some_and(|name| !expected.contains(&name.to_str().unwrap().to_owned()))
Expand Down
5 changes: 2 additions & 3 deletions tests/run-make/output-type-permutations/rmake.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ use std::path::PathBuf;
// `rustc_invocation`: the rustc command being tested
// Any unexpected output files not listed in `must_exist` or `can_exist` will cause a failure.
fn assert_expected_output_files(expectations: Expectations, rustc_invocation: impl Fn()) {
let must_exist = expectations.expected_files;
let can_exist = expectations.allowed_files;
let dir = expectations.test_dir;
let Expectations { expected_files: must_exist, allowed_files: can_exist, test_dir: dir } =
expectations;

fs_wrapper::create_dir(&dir);
rustc_invocation();
Expand Down

0 comments on commit 0332834

Please sign in to comment.