Skip to content

Commit

Permalink
rustdoc: put in rule to get alignment in desktop and mobile layouts
Browse files Browse the repository at this point in the history
  • Loading branch information
notriddle committed Sep 2, 2022
1 parent 6f95c89 commit 0f29824
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/librustdoc/html/static/css/rustdoc.css
Original file line number Diff line number Diff line change
Expand Up @@ -2007,6 +2007,11 @@ in storage.js plus the media query with (min-width: 701px)
#main-content > div > details.rustdoc-toggle > summary::before {
left: -11px;
}

/* Align summary-nested and unnested item-info gizmos. */
.content .impl-items > .item-info {
margin-left: 34px;
}
}

@media print {
Expand Down
10 changes: 10 additions & 0 deletions src/test/rustdoc-gui/item-info-alignment.goml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// This test ensures that the "item-info" looks about the same
// whether or not it's inside a toggle.
goto: file://|DOC_PATH|/lib2/struct.ItemInfoAlignmentTest.html

// First, we try it in "desktop" mode.
size: (1200, 870)
compare-elements-position: (".impl-items > .item-info", "summary > .item-info", ("x"))
// Next, we try it in "mobile" mode (max-width: 700px).
size: (650, 650)
compare-elements-position: (".impl-items > .item-info", "summary > .item-info", ("x"))
10 changes: 10 additions & 0 deletions src/test/rustdoc-gui/src/lib2/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -170,3 +170,13 @@ where
type Output;
fn index(&self, index: Idx) -> &Self::Output;
}

pub struct ItemInfoAlignmentTest;

impl ItemInfoAlignmentTest {
/// This method has docs
#[deprecated]
pub fn foo() {}
#[deprecated]
pub fn bar() {}
}

0 comments on commit 0f29824

Please sign in to comment.