Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tests select when to use --cfg debug, regardless of configure settings.
Remove directive, if present, from CFG_RUSTC_FLAGS. Fix #7898. (One alternative tack is to build up distinct CFG_TEST_RUSTC_FLAGS alongside CFG_RUSTC_FLAGS; but currently debug is the only --cfg flag ever added to CFG_RUSTC_FLAGS; the other contents of CFG_RUSTC_FLAGS are a mix of -Z flags and a few other switches like O, which seem to make sense to propogate to the tests.)
- Loading branch information
1f92557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at pnkfelix@1f92557
1f92557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-issue7898-dont-propagate-cfg-debug-to-tests = 1f92557 into auto
1f92557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-issue7898-dont-propagate-cfg-debug-to-tests = 1f92557 merged ok, testing candidate = b30a16c
1f92557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/565
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/568
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/570
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/563
success: http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/566
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/584
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/587
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/584
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/588
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt-vg/builds/593
success: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/586
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/568
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt/builds/583
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/357
1f92557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = b30a16c