Skip to content

Commit

Permalink
Don't die with an ICE on a blank library name
Browse files Browse the repository at this point in the history
Closes #5425
  • Loading branch information
alexcrichton committed Sep 4, 2013
1 parent 4f151b3 commit 2c573e9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/librustc/back/link.rs
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,10 @@ pub fn build_link_meta(sess: Session,
|| fmt!("output file name `%s` doesn't\
appear to have a stem",
output.to_str())).to_managed();
if name.is_empty() {
sess.fatal("missing crate link meta `name`, and the \
inferred name is blank");
}
warn_missing(sess, "name", name);
name
}
Expand Down

5 comments on commit 2c573e9

@bors
Copy link
Contributor

@bors bors commented on 2c573e9 Sep 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from pnkfelix
at alexcrichton@2c573e9

@bors
Copy link
Contributor

@bors bors commented on 2c573e9 Sep 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/issue-5425 = 2c573e9 into auto

@bors
Copy link
Contributor

@bors bors commented on 2c573e9 Sep 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/issue-5425 = 2c573e9 merged ok, testing candidate = 787f4c9

@bors
Copy link
Contributor

@bors bors commented on 2c573e9 Sep 4, 2013

@bors
Copy link
Contributor

@bors bors commented on 2c573e9 Sep 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 787f4c9

Please sign in to comment.