Add a comment

rust-lang · Jan 10, 2020 · 4a64716 · 4a64716
1 parent 51a73eb
commit 4a64716
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/librustc_mir/monomorphize/collector.rs b/src/librustc_mir/monomorphize/collector.rs
@@ -398,6 +398,9 @@ fn record_accesses<'tcx>(
         mono_item.instantiation_mode(tcx) == InstantiationMode::LocalCopy
     };
 
+    // We collect this into a `SmallVec` to avoid calling `is_inlining_candidate` in the lock.
+    // FIXME: Call `is_inlining_candidate` when pushing to `neighbors` in `collect_items_rec`
+    // instead to avoid creating this `SmallVec`.
     let accesses: SmallVec<[_; 128]> = callees
         .into_iter()
         .map(|mono_item| (*mono_item, is_inlining_candidate(mono_item)))