Skip to content

Commit

Permalink
Pin panic-in-drop=abort test to old pass manager
Browse files Browse the repository at this point in the history
  • Loading branch information
nikic committed Sep 25, 2021
1 parent 3183443 commit 51203dc
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/test/codegen/panic-in-drop-abort.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
// compile-flags: -Z panic-in-drop=abort -O
// compile-flags: -Z panic-in-drop=abort -O -Z new-llvm-pass-manager=no

// Ensure that unwinding code paths are eliminated from the output after
// optimization.

// This test uses -Z new-llvm-pass-manager=no, because the expected optimization does not happen
// on targets using SEH exceptions (i.e. MSVC) anymore. The core issue is that Rust promises that
// the drop_in_place() function can't unwind, but implements it in a way that *can*, because we
// currently go out of our way to allow longjmps, which also use the unwinding mechanism on MSVC
// targets. We should either forbid longjmps, or not assume nounwind, making this optimization
// incompatible with the current behavior of running cleanuppads on longjmp unwinding.

// CHECK-NOT: {{(call|invoke).*}}should_not_appear_in_output

#![crate_type = "lib"]
Expand Down

0 comments on commit 51203dc

Please sign in to comment.