Skip to content

Commit

Permalink
Rollup merge of #54853 - davidtwco:issue-52663-missing-lifetime-sugge…
Browse files Browse the repository at this point in the history
…stion-test, r=nikomatsakis

Remove unneccessary error from test, revealing NLL error.

Part of #52663.

Removes unnecessary type mismatch error from test that was hiding
borrow check error from NLL stderr.

r? @nikomatsakis
  • Loading branch information
pietroalbini authored Oct 5, 2018
2 parents 402c699 + c07b712 commit 51334c9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 28 deletions.
19 changes: 8 additions & 11 deletions src/test/ui/issues/issue-13058.nll.stderr
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
error[E0308]: mismatched types
--> $DIR/issue-13058.rs:36:11
error[E0621]: explicit lifetime required in the type of `cont`
--> $DIR/issue-13058.rs:24:21
|
LL | check((3, 5));
| ^^^^^^
| |
| expected reference, found tuple
| help: consider borrowing here: `&(3, 5)`
|
= note: expected type `&_`
found type `({integer}, {integer})`
LL | fn check<'r, I: Iterator<Item=usize>, T: Itble<'r, usize, I>>(cont: &T) -> bool
| -- help: add explicit lifetime `'r` to the type of `cont`: `&'r T`
LL | {
LL | let cont_iter = cont.iter();
| ^^^^^^^^^^^ lifetime `'r` required

error: aborting due to previous error

For more information about this error, try `rustc --explain E0308`.
For more information about this error, try `rustc --explain E0621`.
3 changes: 1 addition & 2 deletions src/test/ui/issues/issue-13058.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ fn check<'r, I: Iterator<Item=usize>, T: Itble<'r, usize, I>>(cont: &T) -> bool
}

fn main() {
check((3, 5));
//~^ ERROR mismatched types
check(&(3, 5));
}
17 changes: 2 additions & 15 deletions src/test/ui/issues/issue-13058.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,6 @@ LL | {
LL | let cont_iter = cont.iter();
| ^^^^ lifetime `'r` required

error[E0308]: mismatched types
--> $DIR/issue-13058.rs:36:11
|
LL | check((3, 5));
| ^^^^^^
| |
| expected reference, found tuple
| help: consider borrowing here: `&(3, 5)`
|
= note: expected type `&_`
found type `({integer}, {integer})`

error: aborting due to 2 previous errors
error: aborting due to previous error

Some errors occurred: E0308, E0621.
For more information about an error, try `rustc --explain E0308`.
For more information about this error, try `rustc --explain E0621`.

0 comments on commit 51334c9

Please sign in to comment.