Skip to content

Commit

Permalink
Extend cargotest to specify packages to test (within a Cargo workspace).
Browse files Browse the repository at this point in the history
  • Loading branch information
SimonSapin committed Oct 23, 2017
1 parent 4c053db commit 5167aac
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions src/tools/cargotest/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ struct Test {
name: &'static str,
sha: &'static str,
lock: Option<&'static str>,
packages: &'static [&'static str],
}

const TEST_REPOS: &'static [Test] = &[
Expand All @@ -27,30 +28,35 @@ const TEST_REPOS: &'static [Test] = &[
repo: "https://github.com/iron/iron",
sha: "21c7dae29c3c214c08533c2a55ac649b418f2fe3",
lock: Some(include_str!("lockfiles/iron-Cargo.lock")),
packages: &[],
},
Test {
name: "ripgrep",
repo: "https://github.com/BurntSushi/ripgrep",
sha: "b65bb37b14655e1a89c7cd19c8b011ef3e312791",
lock: None,
packages: &[],
},
Test {
name: "tokei",
repo: "https://github.com/Aaronepower/tokei",
sha: "5e11c4852fe4aa086b0e4fe5885822fbe57ba928",
lock: None,
packages: &[],
},
Test {
name: "treeify",
repo: "https://github.com/dzamlo/treeify",
sha: "999001b223152441198f117a68fb81f57bc086dd",
lock: None,
packages: &[],
},
Test {
name: "xsv",
repo: "https://github.com/BurntSushi/xsv",
sha: "4b308adbe48ac81657fd124b90b44f7c3263f771",
lock: None,
packages: &[],
},
];

Expand All @@ -74,7 +80,7 @@ fn test_repo(cargo: &Path, out_dir: &Path, test: &Test) {
.write_all(lockfile.as_bytes())
.expect("");
}
if !run_cargo_test(cargo, &dir) {
if !run_cargo_test(cargo, &dir, test.packages) {
panic!("tests failed for {}", test.repo);
}
}
Expand Down Expand Up @@ -134,9 +140,13 @@ fn clone_repo(test: &Test, out_dir: &Path) -> PathBuf {
out_dir
}

fn run_cargo_test(cargo_path: &Path, crate_path: &Path) -> bool {
let status = Command::new(cargo_path)
.arg("test")
fn run_cargo_test(cargo_path: &Path, crate_path: &Path, packages: &[&str]) -> bool {
let mut command = Command::new(cargo_path);
command.arg("test");
for name in packages {
command.arg("-p").arg(name);
}
let status = command
// Disable rust-lang/cargo's cross-compile tests
.env("CFG_DISABLE_CROSS_TESTS", "1")
.current_dir(crate_path)
Expand Down

0 comments on commit 5167aac

Please sign in to comment.