Skip to content

Commit

Permalink
Auto merge of #56287 - michaelwoerister:bench-incr-ignore-spans, r=<try>
Browse files Browse the repository at this point in the history
[do not merge] Benchmark ignoring span hashes during incr. comp. for getting a lower bound for #47389

I figured that ignoring changes to span values might give a useful lower bound on compile times with the optimizations described in #47389 applied. Keep in mind that any improvements shown with this PR could only be achieved if we could update object files in place, which would be the "stretch goal" for #47389.
  • Loading branch information
bors committed Nov 27, 2018
2 parents 10e2c72 + 135e763 commit 5280d23
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc/ich/hcx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ impl<'a> HashStable<StableHashingContext<'a>> for Span {
const TAG_EXPANSION: u8 = 0;
const TAG_NO_EXPANSION: u8 = 1;

if !hcx.hash_spans {
if !hcx.hash_spans && false {
return
}

Expand Down

0 comments on commit 5280d23

Please sign in to comment.