Skip to content

Commit

Permalink
debuginfo: Fix regression in namespace handling for struct types.
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelwoerister committed Apr 28, 2016
1 parent 6e03608 commit 6074463
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/librustc_trans/debuginfo/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1159,12 +1159,12 @@ fn prepare_struct_metadata<'a, 'tcx>(cx: &CrateContext<'a, 'tcx>,
let struct_name = compute_debuginfo_type_name(cx, struct_type, false);
let struct_llvm_type = type_of::in_memory_type_of(cx, struct_type);

let (variant, substs) = match struct_type.sty {
ty::TyStruct(def, substs) => (def.struct_variant(), substs),
let (struct_def_id, variant, substs) = match struct_type.sty {
ty::TyStruct(def, substs) => (def.did, def.struct_variant(), substs),
_ => bug!("prepare_struct_metadata on a non-struct")
};

let (containing_scope, _) = get_namespace_and_span_for_item(cx, variant.did);
let (containing_scope, _) = get_namespace_and_span_for_item(cx, struct_def_id);

let struct_metadata_stub = create_struct_stub(cx,
struct_llvm_type,
Expand Down
74 changes: 74 additions & 0 deletions src/test/debuginfo/struct-namespace.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Copyright 2013-2016 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-gdb
// compile-flags:-g
// min-lldb-version: 310

// Check that structs get placed in the correct namespace

// lldb-command:run
// lldb-command:p struct1
// lldb-check:(struct_namespace::Struct1) $0 = [...]
// lldb-command:p struct2
// lldb-check:(struct_namespace::Struct2) $1 = [...]
// lldb-command:p struct3
// lldb-check:(struct_namespace::Struct3) $2 = [...]

// lldb-command:p mod1_struct1
// lldb-check:(struct_namespace::mod1::Struct1) $3 = [...]
// lldb-command:p mod1_struct2
// lldb-check:(struct_namespace::mod1::Struct2) $4 = [...]
// lldb-command:p mod1_struct3
// lldb-check:(struct_namespace::mod1::Struct3) $5 = [...]

#![allow(unused_variables)]
#![allow(dead_code)]
#![feature(omit_gdb_pretty_printer_section)]
#![omit_gdb_pretty_printer_section]

struct Struct1;
struct Struct2 {
a: u32,
b: u64,
}
struct Struct3(u32);

mod mod1 {

pub struct Struct1;
pub struct Struct2 {
pub a: u32,
pub b: u64,
}
pub struct Struct3(pub u32);
}


fn main() {
let struct1 = Struct1;
let struct2 = Struct2 {
a: 0,
b: 1,
};
let struct3 = Struct3(2);

let mod1_struct1 = mod1::Struct1;
let mod1_struct2 = mod1::Struct2 {
a: 3,
b: 4,
};
let mod1_struct3 = mod1::Struct3(5);

zzz(); // #break
}

#[inline(never)]
fn zzz() {()}

0 comments on commit 6074463

Please sign in to comment.