Skip to content

Commit

Permalink
Rollup merge of #121850 - reitermarkus:generic-nonzero-unsafe-trait, …
Browse files Browse the repository at this point in the history
…r=Nilstrieb

Make `ZeroablePrimitive` trait unsafe.

Tracking issue: #120257

r? `@dtolnay`
  • Loading branch information
matthiaskrgr authored Mar 1, 2024
2 parents 96e3777 + f6d2607 commit 68dd5e6
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions library/core/src/num/nonzero.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,17 @@ mod private {
/// A marker trait for primitive types which can be zero.
///
/// This is an implementation detail for <code>[NonZero]\<T></code> which may disappear or be replaced at any time.
///
/// # Safety
///
/// Types implementing this trait must be primitves that are valid when zeroed.
#[unstable(
feature = "nonzero_internals",
reason = "implementation detail which may disappear or be replaced at any time",
issue = "none"
)]
#[const_trait]
pub trait ZeroablePrimitive: Sized + Copy + private::Sealed {}
pub unsafe trait ZeroablePrimitive: Sized + Copy + private::Sealed {}

macro_rules! impl_zeroable_primitive {
($primitive:ty) => {
Expand All @@ -46,7 +50,7 @@ macro_rules! impl_zeroable_primitive {
reason = "implementation detail which may disappear or be replaced at any time",
issue = "none"
)]
impl const ZeroablePrimitive for $primitive {}
unsafe impl const ZeroablePrimitive for $primitive {}
};
}

Expand Down

0 comments on commit 68dd5e6

Please sign in to comment.