Skip to content

Commit

Permalink
Switch confusable_idents lint to warn.
Browse files Browse the repository at this point in the history
  • Loading branch information
crlf0710 committed May 1, 2020
1 parent c6a71bc commit 7ff936b
Show file tree
Hide file tree
Showing 22 changed files with 22 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/liballoc/tests/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#![feature(vec_remove_item)]
#![feature(split_inclusive)]
#![feature(binary_heap_retain)]
#![allow(unknown_lints, confusable_idents)]

use std::collections::hash_map::DefaultHasher;
use std::hash::{Hash, Hasher};
Expand Down
1 change: 1 addition & 0 deletions src/libcore/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#![warn(missing_docs)]
#![warn(missing_debug_implementations)]
#![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
#![allow(unknown_lints, confusable_idents)]
#![allow(explicit_outlives_requirements)]
#![allow(incomplete_features)]
#![feature(allow_internal_unstable)]
Expand Down
1 change: 1 addition & 0 deletions src/libcore/tests/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
#![feature(leading_trailing_ones)]
#![feature(const_forget)]
#![feature(option_unwrap_none)]
#![allow(unknown_lints, confusable_idents)]

extern crate test;

Expand Down
1 change: 1 addition & 0 deletions src/librustc_ast/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#![feature(try_trait)]
#![feature(unicode_internals)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_export]
macro_rules! unwrap_or {
Expand Down
1 change: 1 addition & 0 deletions src/librustc_ast_lowering/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#![feature(specialization)]
#![feature(or_patterns)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

use rustc_ast::ast;
use rustc_ast::ast::*;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_codegen_ssa/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#![feature(trusted_len)]
#![feature(associated_type_bounds)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

//! This crate contains codegen code that is used by all codegen backends (LLVM and others).
//! The backend-agnostic functions of this crate use functions defined in various traits that
Expand Down
1 change: 1 addition & 0 deletions src/librustc_data_structures/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#![feature(associated_type_bounds)]
#![feature(thread_id_value)]
#![allow(rustc::default_hash_types)]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate log;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_expand/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#![feature(proc_macro_internals)]
#![feature(proc_macro_span)]
#![feature(try_blocks)]
#![allow(unknown_lints, confusable_idents)]

extern crate proc_macro as pm;

Expand Down
1 change: 1 addition & 0 deletions src/librustc_hir/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#![feature(or_patterns)]
#![feature(specialization)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate rustc_data_structures;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_incremental/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#![feature(in_band_lifetimes)]
#![feature(nll)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate rustc_middle;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_infer/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#![feature(in_band_lifetimes)]
#![feature(crate_visibility_modifier)]
#![recursion_limit = "512"] // For rustdoc
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate rustc_macros;
Expand Down
3 changes: 1 addition & 2 deletions src/librustc_lint/non_ascii_idents.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ declare_lint! {
"detects uncommon Unicode codepoints in identifiers"
}

// FIXME: Change this to warn.
declare_lint! {
pub CONFUSABLE_IDENTS,
Allow,
Warn,
"detects uncommon Unicode codepoints in identifiers"
}

Expand Down
1 change: 1 addition & 0 deletions src/librustc_metadata/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#![feature(specialization)]
#![feature(stmt_expr_attributes)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

extern crate proc_macro;

Expand Down
1 change: 1 addition & 0 deletions src/librustc_middle/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#![feature(hash_raw_entry)]
#![feature(int_error_matching)]
#![recursion_limit = "512"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate bitflags;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_mir/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Rust MIR: a lowered representation of Rust.
#![feature(option_expect_none)]
#![feature(or_patterns)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate log;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_mir_build/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#![feature(bool_to_option)]
#![feature(or_patterns)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate log;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_trait_selection/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#![feature(str_strip)]
#![feature(option_zip)]
#![recursion_limit = "512"] // For rustdoc
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate rustc_macros;
Expand Down
1 change: 1 addition & 0 deletions src/librustc_typeck/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ This API is completely unstable and subject to change.
#![feature(never_type)]
#![feature(slice_partition_dedup)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

#[macro_use]
extern crate log;
Expand Down
1 change: 1 addition & 0 deletions src/librustdoc/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#![feature(crate_visibility_modifier)]
#![feature(never_type)]
#![recursion_limit = "256"]
#![allow(unknown_lints, confusable_idents)]

extern crate env_logger;
extern crate rustc_ast;
Expand Down
1 change: 1 addition & 0 deletions src/libserialize/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Core encoding and decoding interfaces.
#![feature(never_type)]
#![feature(nll)]
#![feature(associated_type_bounds)]
#![allow(unknown_lints, confusable_idents)]
#![cfg_attr(test, feature(test))]
#![allow(rustc::internal)]

Expand Down
1 change: 1 addition & 0 deletions src/libstd/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@
#![warn(missing_docs)]
#![warn(missing_debug_implementations)]
#![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
#![allow(unknown_lints, confusable_idents)]
#![allow(explicit_outlives_requirements)]
#![allow(unused_lifetimes)]
// Tell the compiler to link to either panic_abort or panic_unwind
Expand Down
1 change: 1 addition & 0 deletions src/test/ui/issues/issue-40003.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// run-pass
#![allow(unused_must_use)]
#![allow(unknown_lints, confusable_idents)]
fn main() {
if false { test(); }
}
Expand Down

0 comments on commit 7ff936b

Please sign in to comment.