Skip to content

Commit

Permalink
Auto merge of #28607 - remram44:doc-fix-str-pattern, r=alexcrichton
Browse files Browse the repository at this point in the history
Reported by Moonlightning on #rust
> 17:13 EDT < Moonlightning> I think I found a bug in the str::matches() documentation. Was it copied from str::split()? :p
> 17:13 EDT < Moonlightning> Because it says “The pattern can be a simple `&str`, `char`, or a closure that determines the split.”

I changed "determines the split" to "determines if a character matches".

It's not super clear, "determines the split" is not super clear to begin with, maybe this can be made better? On the other hand following the link to Pattern provides enough details.
  • Loading branch information
bors committed Sep 24, 2015
2 parents f0666b4 + 30fbf44 commit 8fe79bd
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions src/libcollections/str.rs
Original file line number Diff line number Diff line change
Expand Up @@ -715,8 +715,7 @@ impl str {
/// Returns `None` if it doesn't exist.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines the
/// split.
/// determines if a character matches.
///
/// # Examples
///
Expand Down Expand Up @@ -760,7 +759,7 @@ impl str {
/// Returns `None` if it doesn't exist.
///
/// The pattern can be a simple `&str`, `char`,
/// or a closure that determines the split.
/// or a closure that determines if a character matches.
///
/// # Examples
///
Expand Down Expand Up @@ -1096,7 +1095,7 @@ impl str {
/// An iterator over the matches of a pattern within `self`.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines the split.
/// determines if a character matches.
/// Additional libraries might provide more complex patterns like
/// regular expressions.
///
Expand Down Expand Up @@ -1129,7 +1128,7 @@ impl str {
/// reverse order.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines the split.
/// determines if a character matches.
/// Additional libraries might provide more complex patterns like
/// regular expressions.
///
Expand Down Expand Up @@ -1166,8 +1165,7 @@ impl str {
/// match are returned.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines
/// the split.
/// determines if a character matches.
/// Additional libraries might provide more complex patterns like
/// regular expressions.
///
Expand Down Expand Up @@ -1214,8 +1212,7 @@ impl str {
/// match are returned.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines
/// the split.
/// determines if a character matches.
/// Additional libraries might provide more complex patterns like
/// regular expressions.
///
Expand Down Expand Up @@ -1296,7 +1293,7 @@ impl str {
/// repeatedly removed.
///
/// The pattern can be a simple `char`, or a closure that determines
/// the split.
/// if a character matches.
///
/// # Examples
///
Expand Down Expand Up @@ -1326,7 +1323,7 @@ impl str {
/// repeatedly removed.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines the split.
/// determines if a character matches.
///
/// # Examples
///
Expand All @@ -1346,7 +1343,7 @@ impl str {
/// repeatedly removed.
///
/// The pattern can be a simple `&str`, `char`, or a closure that
/// determines the split.
/// determines if a character matches.
///
/// # Examples
///
Expand Down

0 comments on commit 8fe79bd

Please sign in to comment.